[v12.x backport] http: don't throw on Uint8Arrays for http.ServerResponse#write#33488
Closed
rexagod wants to merge 2 commits intonodejs:v12.x-stagingfrom
Closed
[v12.x backport] http: don't throw on Uint8Arrays for http.ServerResponse#write#33488rexagod wants to merge 2 commits intonodejs:v12.x-stagingfrom
Uint8Arrays for http.ServerResponse#write#33488rexagod wants to merge 2 commits intonodejs:v12.x-stagingfrom
Conversation
Don't throw errors on Uint8Arrays and added test for all valid types. Backport-PR-URL: nodejs#33488 PR-URL: nodejs#33155 Fixes: nodejs#33379 Refs: nodejs#29829 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com>
rexagod
force-pushed
the
backport-33155-to-v12.x
branch
from
15cd4f6 to
d2a920c
Compare
Member
Author
|
|
Member
|
Ideally, all commits are backported directly from the following major version. I suggest to wait with this until the backport for v14 landed and see how and if there's need for a manual backport afterwards. |
codebytere
force-pushed
the
v12.x-staging
branch
2 times, most recently
from
b64963e to
3b1d9b3
Compare
danielleadams
approved these changes
Aug 4, 2020
BethGriggs
approved these changes
Aug 4, 2020
Collaborator
shisama
approved these changes
Aug 4, 2020
MylesBorins
pushed a commit
that referenced
this pull request
Aug 18, 2020
Don't throw errors on Uint8Arrays and added test for all valid types. Backport-PR-URL: #33488 PR-URL: #33155 Fixes: #33379 Refs: #29829 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
|
landed in 8069f8d |
jimmy54
pushed a commit
to jimmy54/nodejs-mobile
that referenced
this pull request
Dec 31, 2025
Don't throw errors on Uint8Arrays and added test for all valid types. Backport-PR-URL: nodejs/node#33488 PR-URL: nodejs/node#33155 Fixes: nodejs/node#33379 Refs: nodejs/node#29829 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't throw errors on Uint8Arrays and added test for all
valid types.
PR-URL: #33155
Fixes: #33379
Refs: #29829
Reviewed-By: Robert Nagy ronagy@icloud.com
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Zeyu Yang himself65@outlook.com
Reviewed-By: James M Snell jasnell@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes